DragonFly submit List (threaded) for 2007-01
DragonFly BSD
DragonFly submit List (threaded) for 2007-01
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: multi-vkd support patch for review


From: "Simon 'corecode' Schubert" <corecode@xxxxxxxxxxxx>
Date: Sun, 28 Jan 2007 18:08:58 +0100

Thomas E. Spanjaard wrote:
Sepherosa Ziehau wrote:
On 1/28/07, Thomas E. Spanjaard <tgen@netphreax.net> wrote:
C.Turner wrote:
> +                     if ( vkdFileNum < VKD_MAX )
> +                             vkdFile[vkdFileNum++] = optarg;
Why not if (vkdFileNum < VKD_MAX) { vkdFile[vkdFileNum] = optarg;
vkdFileNum++; }; ? Because now it appears '16' is a valid number, where
Why '16'(VKD_MAX) will be a valid number in his patch?
if (15 < 16) { vkdFile[(15++ = 16)] = optarg; }

heh, no :)


% cat<<EOF>d.c
main(){int i=0;printf("%d\n", i++);}
EOF
% cc d.c
% ./a.out
0
%

cheers
 simon

--
Serve - BSD     +++  RENT this banner advert  +++    ASCII Ribbon   /"\
Work - Mac      +++  space for low €€€ NOW!1  +++      Campaign     \ /
Party Enjoy Relax   |   http://dragonflybsd.org      Against  HTML   \
Dude 2c 2 the max   !   http://golden-apple.biz       Mail + News   / \

Attachment: signature.asc
Description: OpenPGP digital signature



[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]