DragonFly submit List (threaded) for 2007-01
DragonFly BSD
DragonFly submit List (threaded) for 2007-01
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: multi-vkd support patch for review


From: "Sepherosa Ziehau" <sepherosa@xxxxxxxxx>
Date: Sun, 28 Jan 2007 21:31:23 +0800

On 1/28/07, Thomas E. Spanjaard <tgen@netphreax.net> wrote:
C.Turner wrote:
> @@ -159,7 +161,8 @@
>                               netifFile[netifFileNum++] = optarg;
>                       break;
>               case 'r':
> -                     rootImageFile = optarg;
> +                     if ( vkdFileNum < VKD_MAX )
> +                             vkdFile[vkdFileNum++] = optarg;
>                       break;
>               case 'm':
>                       Maxmem_bytes = strtoull(optarg, &suffix, 0);

Why not if (vkdFileNum < VKD_MAX) { vkdFile[vkdFileNum] = optarg;
vkdFileNum++; }; ? Because now it appears '16' is a valid number, where

Why '16'(VKD_MAX) will be a valid number in his patch?


Best Regards,
sephe

--
Live Free or Die



[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]