Re: unbreak individual module building

["Sepherosa Ziehau" <sepherosa@xxxxxxxxx>]

On 11/16/06, YONETANI Tomokazu <qhwt+dfly@xxxxxxxxxx> wrote:
> On Wed, Nov 15, 2006 at 07:54:30PM +0800, Sepherosa Ziehau wrote:
> > On 11/15/06, Sepherosa Ziehau <sepherosa@xxxxxxxxx> wrote:
> > >On 11/15/06, Simon 'corecode' Schubert <corecode@xxxxxxxxxxxx> wrote:
> > >> Sepherosa Ziehau wrote:
> > >> >>    Because of all this the buildworld (in src/include/Makefile*) and
> > >> >>    buildkernel (in src/Makefile.inc1) targets synthesize the 'missing'
> > >> >>    <machine/*.h> header files by either creating a forwarding header
> > >> >>    file to <cpu/*.h> or simply copying the <cpu/*.h> to the machine/
> > >> >>    sub directory in the object tree or in /usr/include.
> > >> >
> > >> > I prefer to synthesizing missing headers:
> > >> > http://leaf.dragonflybsd.org/~sephe/config2.diff
> > >> >
> > >> > Please review it.
> > >>
> > >> possibly a nitpick, but:  won't that break when you ^C config while
> > >creating the forwarding headers?  maybe the target should be something
> > >like ${_MACHINE_INC}/.done, which gets touch'ed after running config?
> >
> > Please review it:
> > http://leaf.dragonflybsd.org/~sephe/config3.diff
> >
> > If no objection, I will commit it on this Friday.
>
> Hi, just a bikeshed now that you have an already working patch :), but
> the generate_forwarding_headers() can be implemented as kernel make rules:
>
>   http://les.ath.cx/DragonFly/fwd_hdr.diff.gz

I think it is better and cleaner than generating headers in config(8),
I have adjusted YONETANI's version a little bit, mainly in kmod.mk
1) use forwarder_${MACHINE_ARCH} instead of forwarder_i386
2) if MAKEOBJDIRPREFIX is not set, ${.OBJDIR}/forward_${MACHINE_ARCH}
is used, or forward_${MACHINE_ARCH} will be created in /usr/src/sys,
that's probably not what we want
3) nuke generate_forwarding_headers() in usr.sbin/config/main.c

Please review it:
http://leaf.dragonflybsd.org/~sephe/fwd_hdr1.diff

Best Regards,
sephe

--
Live Free or Die