DragonFly BSD
DragonFly submit List (threaded) for 2006-11
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: unbreak individual module building


From: YONETANI Tomokazu <qhwt+dfly@xxxxxxxxxx>
Date: Thu, 16 Nov 2006 13:20:16 +0900

On Wed, Nov 15, 2006 at 07:54:30PM +0800, Sepherosa Ziehau wrote:
> On 11/15/06, Sepherosa Ziehau <sepherosa@xxxxxxxxx> wrote:
> >On 11/15/06, Simon 'corecode' Schubert <corecode@xxxxxxxxxxxx> wrote:
> >> Sepherosa Ziehau wrote:
> >> >>    Because of all this the buildworld (in src/include/Makefile*) and
> >> >>    buildkernel (in src/Makefile.inc1) targets synthesize the 'missing'
> >> >>    <machine/*.h> header files by either creating a forwarding header
> >> >>    file to <cpu/*.h> or simply copying the <cpu/*.h> to the machine/
> >> >>    sub directory in the object tree or in /usr/include.
> >> >
> >> > I prefer to synthesizing missing headers:
> >> > http://leaf.dragonflybsd.org/~sephe/config2.diff
> >> >
> >> > Please review it.
> >>
> >> possibly a nitpick, but:  won't that break when you ^C config while 
> >creating the forwarding headers?  maybe the target should be something 
> >like ${_MACHINE_INC}/.done, which gets touch'ed after running config?
> 
> Please review it:
> http://leaf.dragonflybsd.org/~sephe/config3.diff
> 
> If no objection, I will commit it on this Friday.

Hi, just a bikeshed now that you have an already working patch :), but
the generate_forwarding_headers() can be implemented as kernel make rules:

  http://les.ath.cx/DragonFly/fwd_hdr.diff.gz

Cheers.



[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]