Re: DragonFly-2.3.0.828.gd7215 master sys/dev/netif/emx if_emx.h

[Sepherosa Ziehau <sepherosa@xxxxxxxxx>]

On Wed, Apr 29, 2009 at 1:55 AM, Matthew Dillon
<dillon@apollo.backplane.com> wrote:
> :commit d721525ce4a5d67b7fddb8568a3c4bb5a5e95200
> :Author: Sepherosa Ziehau <sephe@dragonflybsd.org>
> :Date:   Tue Apr 28 23:03:37 2009 +0800
> :
> :    emx(4): __cachealign struct emx_rxdata
> :
> :Summary of changes:
> : sys/dev/netif/emx/if_emx.h |    2 +-
> : 1 files changed, 1 insertions(+), 1 deletions(-)
> :
> :http://gitweb.dragonflybsd.org/dragonfly.git/commitdiff/d721525ce4a5d67b7fddb8568a3c4bb5a5e95200
>
>    It might be better to align this in the struct emx_softc rather
>    then making it an attribute of the struct emx_rxdata structure.

Yeah.  However, could you tell me the major reason you want to put
__cachealign in struct field?  I guess you worried about emx_rxdata
being used outside of emx_softc?

Best Regards,
sephe

-- 
Live Free or Die