DragonFly commits List (threaded) for 2009-04
DragonFly BSD
DragonFly commits List (threaded) for 2009-04
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: DragonFly-2.3.0.828.gd7215 master sys/dev/netif/emx if_emx.h


From: Matthew Dillon <dillon@xxxxxxxxxxxxxxxxxxxx>
Date: Tue, 28 Apr 2009 18:42:45 -0700 (PDT)

:Yeah.  However, could you tell me the major reason you want to put
:__cachealign in struct field?  I guess you worried about emx_rxdata
:being used outside of emx_softc?
:
:Best Regards,
:sephe

    It's more obvious that the array needs to be cache-aligned if it is
    in the softc structure.  Also, it's more C-like.  Putting storage
    attributes on structural definitions is not very C-like.  The storage
    attributes should be on declarations instead.

					-Matt
					Matthew Dillon 
					<dillon@backplane.com>



[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]