Re: RegressionTest Results

[Dylan Reinhold <dylan@xxxxxxxxxxxxxxxx>]

On 11/26/2010 01:16 AM, Eric Bakan wrote:
> Here are the results of running the pcca-test framework.
Thanks Eric.

I looked at the first two
> [ 1/ 1] /aio.h/t_aio: Assertion failed: (aio_read(&iocb) != -1),
> function main, file t_aio.c, line 57.
> [ 1/ 1] /aio.h/t_aio_suspend: Assertion failed: (lio_listio(LIO_WAIT,
> iocblist, NAIO, NULL) == 0), function main, file t_aio_suspend.c, line 71.

aio is not enabled in the default kernel so not much to see here. It's 
returning ENOSYS.

---CUT---
> [ 1/ 1] /fnmatch.h/t_fnmatch: Assertion failed: (rv == FNM_NOMATCH),
> function main, file t_fnmatch.c, line 40.
> [ 1/ 1] /fnmatch.h/t_fnmatch2: passed

The test case that is failing is
rv = fnmatch("\\", "\\", 0);
assert(rv == FNM_NOMATCH);

Now without FNM_NOESCAPE fnmatch says it will treat the backslash as an 
escape and use the next character in the string to try and match with.
It does not say it will do anything special when the next character is null.

So so it seems that pattern should not match.
Just like this one that does not return a match :
fnmatch("\\string", "\\string", 0);

This will incorrectly match :
fnmatch("string\\", "string\\", 0);

This patch changes the trailing backslashes from matching.
http://leaf.dragonflybsd.org/~dylan/0001-fnmatch-Fix-edge-case-with-trailing-blackslash.patch

Dylan