Re: est module

[YONETANI Tomokazu <qhwt+dfly@xxxxxxxxxx>]

On Thu, Jun 22, 2006 at 03:36:38PM +0200, joerg@xxxxxxxxxxxxxxxxx wrote:
> On Thu, Jun 22, 2006 at 02:42:58PM +0200, Thomas Schlesinger wrote:
> > Unfortunately, it seems not to support my Pentium-M 1.73GHz (Pentium M-740, 
> > 533MHz FSB):
> 
> NetBSD has
> /* Intel Pentium M processor 740 1.73 GHz */
> static const struct fq_info pentium_m_n740[] = {
>        { 1733, 1356 },
>        { 1333, 1212 },
>        { 1067, 1100 },
>        {  800,  988 },
> };
> 
> static const struct fqlist pentium_m_dothan[] = {
> 	...
>         ENTRY("1.73", 0x06d8, pentium_m_n740, 4),
> 	...
> };
> 
> Try to adopt it.

I'm starting to feel that we'd probably get a better EST support
to port from NetBSD for now than sticking with the current version,
since FreeBSD decided to rely on _PSS object in ACPI table to
retrieve voltage/frequency data for newer/yet-to-be documented
Pentium-M CPUs, and we haven't ported it yet and probably that'll take
longer than to port NetBSD version of EST driver.

So my question is: Thomas(and anybody else), can you try my untested
patch and see if it works for you? (untested because I don't have
access to any Pentium-M machines now)

$ cd /sys/dev/est
$ export MAKEOBJDIRPREFIX=$HOME/obj		(/bin/sh syntax)
$ setenv MAKEOBJDIRPREFIX $HOME/obj		(/bin/csh syntax)

$ fetch -o est.c http://les.ath.cx/DragonFly/netbsd-est.c
$ make cleandir; make cleandir
$ make obj && make depend && make
$ su
# make install
(make sure you don't have `est_load="YES"' line
in /boot/loader.conf or /etc/sysctl.conf now)

# shutdown now
# umount -a; mount -ur /
(so as your partitions won't get damaged on kernel panic)

Good luck.