Re: Fixes for ath(4)

[Rui Paulo <rpaulo@xxxxxxxxxxx>]

On 17 Apr 2010, at 13:30, Antonio Huete Jimenez wrote:

> Hi all,
> 
> Can somebody please review the following patches?
> 
> http://leaf.dragonflybsd.org/~tuxillo/archive/patches/0001-x86_64-Sync-wlan-options-with-GENERIC.patch
> http://leaf.dragonflybsd.org/~tuxillo/archive/patches/0002-ath-Fix-module-loading.patch
> 
> The first one is to hook up the wlan changes to X86_64, and the second
> one just brings the code from the previous release. Basically it is to
> register the modules ath_hal and ath_rate properly and make them a
> dependency for if_ath.
> They allowed me to use ath(4) on x86_64 where now it isn't possible.

Looks ok, but I would remove:
+		kprintf("ath_hal loaded\n");

> Also, there are two remaining issues that I'm aware of :
> * You need to issue 'ifconfig wlan0 create wlandev ath0' and use wlan0
> instead of ath0 as it was previously. Can this be somehow automated?

In rc.conf:
wlans_ath0="wlan0"
ifconfig_wlan0="WPA DHCP"

> * If you create the clone 'wlan0' and you issue a 'kldunload if_ath'
> the system is totally frozen, not responding to any input from
> keyboard.

I'll look into this.

Regards,
--
Rui Paulo