DragonFly submit List (threaded) for 2008-11
DragonFly BSD
DragonFly submit List (threaded) for 2008-11
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: fix random setsockopt failure (EINVAL)


From: Aggelos Economopoulos <aoiko@xxxxxxxxxxxxxx>
Date: Sun, 23 Nov 2008 12:59:22 +0200

Sepherosa Ziehau wrote:
> Hi all,
> 
> Following patch should fix random setsockopt failure (EINVAL) in HEAD:
> http://leaf.dragonflybsd.org/~sephe/sockopt.diff
> 
> In addition to that:
> - Don't do copyout in setsockopt; the user arg is const
> - Always setup sopt (i.e. set sopt.sopt_val to NULL early)
> - In sys_getsocktopt(), centralize valsize check
> 
> Please review/test it.

Looks good. Feeling a bit embarrassed btw :)

Aggelos




[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]