Re: Announcing ethernet link state changes via route socket

["Sepherosa Ziehau" <sepherosa@xxxxxxxxx>]

On 3/16/07, Hasso Tepper <hasso@estpak.ee> wrote:
> Announcing link state changes to the userspace via route socket is critical
> to get routing related applications to work correctly - routing protocols
> are most important, but other applications might benefit from it as well.

Yah.

> This code is adapted from OpenBSD and is only the first basic step in path
> to get correct support. Only em(4) is tested because I don't have hardware
> to test others, although bge(4) might get my attention as well in the
> future.

I think your changes do affect all mii aware NICs (almost all modern NICs :)

> There is one fundamental problem I'd like to get feedback about from
> developers - how to make various kernel stuff react on link state changes?
> For example various interfaces which are somehow attached to the interface
> (bridges, carp, vlans etc) should react. Ideally routing table should react

I think bridge's link state change support has already been in place,
but is commented out.

For current vlan implementation, I am afraid you will have to go
through all vlan ifaces to locate vlan ifaces backed by the specific
state changing NIC.

BTW, this patch looks OK to me.

Best Regards,
sephe

--
Live Free or Die