Re: [PATCH] fix for isprint(3)

[Joerg Sonnenberger <joerg@xxxxxxxxxxxxxxxxx>]

On Sat, May 07, 2005 at 04:09:33PM +0900, YONETANI Tomokazu wrote:
> > Ok, turned out that this patch doesn't cope with rune <-> ctype
> > conversions. I gave up messing with it and just backed out the
> > last commit so as to unbreak some basic tools.
> 
> Anyway, I took a further look at files in lib/libc/locale, and
> I think attached patch should fix the isprint() problem
> (I'm in the process of rebuilding all the ports after the
> libc version bump, with this patch applied).

Yes, it would solve the problem.

> Adding another _x macro in ctype.h should probably be OK, since
> names beginning with an underscore followed by an uppercase letter
> are reserved(I made sure it's not used elsewhere in the DragonFly
> source tree by running the following command)
>   $ grep -r '[^a-zA-Z0-9_]_W[^a-zA-Z0-9_]' /usr/src
> 
> This patch requires full buildworld and probably rebuild of
> any programs depending on ctype(3) macros, because it changes
> the meaning of bits in the libc_ctype table.

Actually, I think we should just make both isgraph and isprint have
there own bits and initialize them correctly.

Joerg