Re: pf / pflog rc.d patch

["Simon 'corecode' Schubert" <corecode@xxxxxxxxxxxx>]

On Wednesday, 9. February 2005 00:40, Pawel Biernacki wrote:
> hi,
>
> i've found some bug in pf / pflog scripts in /etc/rc.d. my /etc/rc.conf
> includes:
>
>  pf_enable="YES"
>  pflog_enable="YES"
>
> then, while system boot i see some errors:
>
>  kldload: can't load pflog: No such file or directory
>  /etc/rc: ERROR: pflog module failed to load.
>  /etc/rc: INFO: pf module loaded.
>  Enabling pf.
>
> looks like pflog don't work without pf, probably because then they
> don't have anything to log ;), so i've changed REQUIRE field's in
> both scripts and then they starts and work fine without any errors. patch
> included:

thanks for your effort, though this is the wrong fix.

correct one taken from freebsd rev 1.2: load pf, as it includes pflog now.

<http://oly.corecode.ath.cx/~corecode/cgi-bin/crosscgi.py/changeset-240656.diff?cmd=changeset&revid=240656>

cheers
  simon

-- 
/"\
\ /
 \     ASCII Ribbon Campaign
/ \  Against HTML Mail and News

Changeset for FreeBSD src/etc/rc.d/pflog 1.2
Don't rely on properly setup linker.hints to figure out that pflog is now
part of the pf module.
While here fix a comment that was c'n'ped from rc.d/pf

PR:		bin/71096 (partly)
Submitted by:	Ville-Pertti Keinonen
MFC after:	2 days

Index: src/etc/rc.d/pflog
diff -u src/etc/rc.d/pflog:1.1 src/etc/rc.d/pflog:1.2
--- src/etc/rc.d/pflog:1.1	Fri Apr  2 21:25:27 2004
+++ src/etc/rc.d/pflog	Tue Aug 31 16:23:51 2004
@@ -1,6 +1,6 @@
 #!/bin/sh
 #
-# $FreeBSD: src/etc/rc.d/pflog,v 1.1 2004/04/02 19:25:27 mlaier Exp $
+# $FreeBSD: src/etc/rc.d/pflog,v 1.2 2004/08/31 14:23:51 mlaier Exp $
 #
 
 # PROVIDE: pflog
@@ -27,7 +27,7 @@
 {
 	# load pflog kernel module if needed
 	if ! kldstat -v | grep -q pflog\$; then
-		if kldload pflog; then
+		if kldload pf; then
 			info 'pflog module loaded.'
 		else
 			err 1 'pflog module failed to load.'
@@ -39,7 +39,7 @@
 		warn 'pflog: COULD NOT SET UP pflog0'
 	fi
 
-	# check for pf rules
+	# check for pflogd binary
 	if [ ! -x "${pflog_program:-/sbin/pflogd}" ]
 	then
 		warn 'pflog: NO PFLOGD BINARY FOUND'

Attachment: pgp00002.pgp
Description: PGP signature