Re: /usr/bin WARN6 cleanups

[Chris Pressey <cpressey@xxxxxxxxxxxxxxx>]

On Sat, 15 Jan 2005 15:11:18 -0500
Larry Lansing <lansil@xxxxxxxxxxxxx> wrote:

> All of these /usr/bin programs except for 'column' compile fine with
> WARNS?=6, but have a lower warning level set (if any).  This patch
> raises their warning level to 6.  It also adds a one-line patch to
> column to make it compile cleanly, too.

Committed, thanks!

-Chris

> --
> Larry Lansing
> 
> 
> 
> Index: banner/Makefile
> ===================================================================
> RCS file: /home/dcvs/src/usr.bin/banner/Makefile,v
> retrieving revision 1.2
> diff -u -r1.2 Makefile
> --- banner/Makefile	17 Jun 2003 04:29:25 -0000	1.2
> +++ banner/Makefile	6 Feb 2005 11:52:58 -0000
> @@ -5,6 +5,6 @@
>  PROG=	banner
>  MAN=	banner.6
>  
> -WARNS?=	2
> +WARNS?=	6
>  
>  .include <bsd.prog.mk>
> Index: basename/Makefile
> ===================================================================
> RCS file: /home/dcvs/src/usr.bin/basename/Makefile,v
> retrieving revision 1.2
> diff -u -r1.2 Makefile
> --- basename/Makefile	17 Jun 2003 04:29:25 -0000	1.2
> +++ basename/Makefile	17 Jan 2005 03:42:01 -0000
> @@ -3,7 +3,7 @@
>  # $DragonFly: src/usr.bin/basename/Makefile,v 1.2 2003/06/17 04:29:25 dillon Exp $
>  
>  PROG=	basename
> -WARNS?=	2
> +WARNS?=	6
>  MLINKS=	basename.1 dirname.1
>  
>  .include <bsd.prog.mk>
> Index: brandelf/Makefile
> ===================================================================
> RCS file: /home/dcvs/src/usr.bin/brandelf/Makefile,v
> retrieving revision 1.3
> diff -u -r1.3 Makefile
> --- brandelf/Makefile	31 Jan 2004 06:56:43 -0000	1.3
> +++ brandelf/Makefile	17 Jan 2005 05:31:47 -0000
> @@ -2,6 +2,6 @@
>  # $DragonFly: src/usr.bin/brandelf/Makefile,v 1.3 2004/01/31 06:56:43 dillon Exp $
>  
>  PROG=	brandelf
> -WARNS?=	2
> +WARNS?=	6
>  
>  .include <bsd.prog.mk>
> Index: catman/Makefile
> ===================================================================
> RCS file: /home/dcvs/src/usr.bin/catman/Makefile,v
> retrieving revision 1.1
> diff -u -r1.1 Makefile
> --- catman/Makefile	25 Mar 2004 18:05:48 -0000	1.1
> +++ catman/Makefile	17 Jan 2005 02:45:33 -0000
> @@ -2,5 +2,6 @@
>  # $DragonFly: src/usr.bin/catman/Makefile,v 1.1 2004/03/25 18:05:48 joerg Exp $
>  
>  PROG=	catman
> +WARNS?=	6
>  
>  .include <bsd.prog.mk>
> Index: checkpt/Makefile
> ===================================================================
> RCS file: /home/dcvs/src/usr.bin/checkpt/Makefile,v
> retrieving revision 1.2
> diff -u -r1.2 Makefile
> --- checkpt/Makefile	23 Nov 2004 06:32:39 -0000	1.2
> +++ checkpt/Makefile	14 Jan 2005 10:30:07 -0000
> @@ -1,6 +1,7 @@
>  # $DragonFly: src/usr.bin/checkpt/Makefile,v 1.2 2004/11/23 06:32:39 dillon Exp $
>  
>  PROG=	checkpt
> +WARNS?=	6
>  SRCS=	checkpt.c
>  NOSHARED?=      YES
>  
> Index: cmp/Makefile
> ===================================================================
> RCS file: /home/dcvs/src/usr.bin/cmp/Makefile,v
> retrieving revision 1.2
> diff -u -r1.2 Makefile
> --- cmp/Makefile	17 Jun 2003 04:29:25 -0000	1.2
> +++ cmp/Makefile	14 Jan 2005 11:35:36 -0000
> @@ -3,6 +3,7 @@
>  #	@(#)Makefile	8.1 (Berkeley) 6/6/93
>  
>  PROG=	cmp
> +WARNS?=	6
>  SRCS=	cmp.c misc.c regular.c special.c
>  
>  .include <bsd.prog.mk>
> Index: colcrt/Makefile
> ===================================================================
> RCS file: /home/dcvs/src/usr.bin/colcrt/Makefile,v
> retrieving revision 1.2
> diff -u -r1.2 Makefile
> --- colcrt/Makefile	17 Jun 2003 04:29:25 -0000	1.2
> +++ colcrt/Makefile	14 Jan 2005 11:56:48 -0000
> @@ -3,6 +3,6 @@
>  # $DragonFly: src/usr.bin/colcrt/Makefile,v 1.2 2003/06/17 04:29:25 dillon Exp $
>  
>  PROG=	colcrt
> -WARNS?=	2
> +WARNS?=	6
>  
>  .include <bsd.prog.mk>
> Index: colrm/Makefile
> ===================================================================
> RCS file: /home/dcvs/src/usr.bin/colrm/Makefile,v
> retrieving revision 1.2
> diff -u -r1.2 Makefile
> --- colrm/Makefile	17 Jun 2003 04:29:25 -0000	1.2
> +++ colrm/Makefile	14 Jan 2005 12:10:29 -0000
> @@ -3,6 +3,6 @@
>  # $DragonFly: src/usr.bin/colrm/Makefile,v 1.2 2003/06/17 04:29:25 dillon Exp $
>  
>  PROG=	colrm
> -WARNS?=	2
> +WARNS?=	6
>  
>  .include <bsd.prog.mk>
> Index: column/Makefile
> ===================================================================
> RCS file: /home/dcvs/src/usr.bin/column/Makefile,v
> retrieving revision 1.1
> diff -u -r1.1 Makefile
> --- column/Makefile	17 Jun 2003 02:56:03 -0000	1.1
> +++ column/Makefile	14 Jan 2005 12:17:20 -0000
> @@ -1,6 +1,7 @@
>  #	@(#)Makefile	8.1 (Berkeley) 6/6/93
>  
>  PROG=	column
> +WARNS?=	6
>  CFLAGS+=-Wall
>  
>  .include <bsd.prog.mk>
> Index: column/column.c
> ===================================================================
> RCS file: /home/dcvs/src/usr.bin/column/column.c,v
> retrieving revision 1.4
> diff -u -r1.4 column.c
> --- column/column.c	3 Nov 2003 19:31:29 -0000	1.4
> +++ column/column.c	14 Jan 2005 12:23:51 -0000
> @@ -63,7 +63,7 @@
>  int eval;			/* exit value */
>  int maxlength;			/* longest record */
>  char **list;			/* array of pointers to records */
> -char *separator = "\t ";	/* field separator for table option */
> +const char *separator = "\t ";	/* field separator for table option */
>  
>  int
>  main(int argc, char **argv)
> Index: comm/Makefile
> ===================================================================
> RCS file: /home/dcvs/src/usr.bin/comm/Makefile,v
> retrieving revision 1.1
> diff -u -r1.1 Makefile
> --- comm/Makefile	17 Jun 2003 02:56:03 -0000	1.1
> +++ comm/Makefile	14 Jan 2005 12:30:13 -0000
> @@ -1,6 +1,7 @@
>  #	@(#)Makefile	8.1 (Berkeley) 6/6/93
>  
>  PROG=	comm
> +WARNS?=	6
>  CFLAGS+=-Wall
>  
>  .include <bsd.prog.mk>
> Index: compress/Makefile
> ===================================================================
> RCS file: /home/dcvs/src/usr.bin/compress/Makefile,v
> retrieving revision 1.2
> diff -u -r1.2 Makefile
> --- compress/Makefile	17 Jun 2003 04:29:25 -0000	1.2
> +++ compress/Makefile	14 Jan 2005 12:43:05 -0000
> @@ -3,6 +3,7 @@
>  # $DragonFly: src/usr.bin/compress/Makefile,v 1.2 2003/06/17 04:29:25 dillon Exp $
>  
>  PROG=	compress
> +WARNS?=	6
>  SRCS=	compress.c zopen.c
>  LINKS=	${BINDIR}/compress ${BINDIR}/uncompress
>  MLINKS=	compress.1 uncompress.1
>