Re: sysctl warns6 cleanup

[Chris Pressey <cpressey@xxxxxxxxxxxxxxx>]

On Sat, 8 Jan 2005 17:17:17 +0100
Peter Schuller <peter.schuller@xxxxxxxxxxxx> wrote:

> Attached.

And almost identical to the one I did independently a few days ago which
I haven't committed yet :)

The only difference is that I used a seperate const char * variable
instead of 'var' when it's being assigned " " and "", since that seemed
(to me) to be a confusing reuse (re-abuse?) of the variable 'var' for a
different purpose (output spacing).

(In general, reusing a variable for a different purpose is a bad idea. 
It seems to be an old habit of people who started out coding in
assembly language or BASIC.  But by using dataflow analysis, modern C
compilers can optimize to the extent that two variables whose usage
doesn't overlap can share the same storage.  So it's completely
unnecessary nowadays, not to mention horribly confusing.)

I'll commit it later today.

-Chris