Re: Cleanup Base: fetch

[Jeandre du Toit <jeandre.dutoit@xxxxxxxxx>]

Thanks for all the help!

I have started looking at applying the patches and need to know a few
things. From what I can see it makes the most sense to upgrade to the
latest version of the RELENG_4 branch, is this correct? Another thing
that has been puzzling me is

* $FreeBSD: src/lib/libfetch/fetch.h,v 1.10.2.8 2002/07/26 11:10:54 des Exp $
* $FreeBSD: /usr/local/www/cvsroot/FreeBSD/src/lib/libfetch/fetch.c,v
1.11 2000/05/07 20:02:52 des Exp $

Why is the version number higher but the date futher into the past?
When I commit a patch from FreeBSD should I include the above version
number change? When do you know to commit patches from FreeBSD, do you
just systematically check their site for updates?

Sorry for about all the questions. I am sure once all things I don't
understand has been explained I can start sending more patches,
faster.

Thanks again
Jeandre du Toit


On Wed, 5 Jan 2005 16:30:59 +0000, Liam J Foy <liamfoy@xxxxxxxxxxxxx> wrote:
> On Wed(05)/Jan/05 - , Jeandre du Toit wrote:
> > I am sorry, like I said before this is the first time I submit
> > patches. I actually have no clue what you are speaking about. If you
> > don't mind explaining I am sure that whatever it is you are asking
> > won't be a problem.
> >
> >
> >
> > Jeandre du Toit
> >
> >
> > On Wed, 5 Jan 2005 10:39:24 +0100, Eirik Nygaard <eirikn@xxxxxxxxxxxx> wrote:
> > > On Tue, Jan 04, 2005 at 11:26:12PM +0200, Jeandre du Toit wrote:
> > > > Hi,
> > >
> > > Hello,
> > >
> > > do you want to get the fetch and libfetch updates done in the FreeBSD tree as
> > > well? Almost every patch could be applied cleanly, except for some printf
> > > changes that depend on gcc3-ism.
> > >
> > > --
> > > Eirik Nygaard
> > >
> 
> Hello,
> 
> What he basically means is look at the changes FreeBSD have made to there
> libfetch and apply them to our tree(our libfetch).
> 
> If you wish to do it, you can look at :
> http://www.freebsd.org/cgi/cvsweb.cgi/src/lib/libfetch/
> 
> The above URL will show you the changes FreeBSD have made.
> 
> Once you have applied them to our source, diff them (like you did in your
> other patch) and send them to submit@. If you require any help, please feel
> free to ask.
> 
> --
> - Liam J. Foy
> <liamfoy@xxxxxxxxxxxxx>
>