Re: acpica5 and acpi sub-modules (Re: cvs commit: src/sys/dev Makefile)

[Matthew Dillon <dillon@xxxxxxxxxxxxxxxxxxxx>]

    Ok, this looks like it is starting to shape up.  There are a few problems
    with the patch that need to be fixed but once that is accomplished
    I think it looks committable.  You did a lot of work bringing in the
    FreeBSD-5 changes!  Thanks!  FreeBSD-5 has made significant progress in
    the last few months and we definitely need that work.

    The first issue with the patch is that you have to move the acpi.h and
    acenv.h generation back into acpica5/Makefile and remove it from 
    /usr/src/sys/Makefile.inc.  The problem is that /usr/src/sys/Makefile.inc
    covers *everything* under sys and those acpica dependancies not only
    do not belong there, but the ../../.... paths won't be correct for many
    subdirectories under sys.  This leads to make depend problems (amoung
    other things).

    The second issue is the addition of dev/acpi.  This seems to have taken
    over the build that used to be in acpica5.  The build should really be
    in acpica5 with appropriate rearrangements to accomodate your new 
    subdirectory structure (which I think is fine).  Putting the build
    in dev/acpi creates a lot of confusion between dev/acpi and dev/acpica5.

    I am also a bit unsure about the idle hook you added, but since acpica5
    is still experimental I think we can run with it until we find a better
    way.

    If you can fix those two issues and supply a new patch, I think it
    could be committed.

					-Matt
					Matthew Dillon 
					<dillon@xxxxxxxxxxxxx>

:Hi.
:On Thu, Apr 29, 2004 at 08:15:56AM +0000, David Rhodus wrote:
:> Sorry about the delay in sending a message back. I've been switching 
:> mail clients, from iMail over to Mozilla. The message flagging needs 
:> still some more work. :-) I'll take a look at this patch today.
:
:If you haven't look at the previous patch, and still have time to do so,
:please look at the new patch instead:
:    http://les.ath.cx/DragonFly/acpi-update.patch.gz
:
:This brings in the recent changes to FreeBSD-CURRENT's acpi code.
:A few things to note:
:- The patch only works when compiled as a module, since I haven't tweaked
:  files under /sys/conf yet. In case something went wrong, type
:    set int.acpi.0.disabled=1
:  in the boot loader prompt, so that acpi module is not loaded.
:- You have to recompile the kernel, otherwise the new acpi module won't
:  load because I added a hook to cpu_idle().
:- acpivar.h is from rev 1.64, because 1.65 panicked two DragonFly boxes
:  (and there's been a few panic reports on freebsd-current)
:- contrib tree is not modified.
:- acpi_video and acpi_asus is not added because of lack of hardware to test.
:
:Thanks.