Re: src/sys/vfs ANSIfication

[Hiten Pandya <hmp@xxxxxxxxxxxxx>]

11D8-85F0-00039380DD2C@xxxxxxxxxxx>
In-Reply-To: <8D46D916-824C-11D8-85F0-00039380DD2C@xxxxxxxxxxx>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Lines: 34
NNTP-Posting-Host: 81.99.109.92
X-Trace: 1080652960 crater_reader.dragonflybsd.org 50171 81.99.109.92
Xref: crater_reader.dragonflybsd.org dragonfly.submit:1142

David Rhodus wrote:
> 
> On Mar 30, 2004, at 12:33 AM, Chris Pressey wrote
> 
>> While on the subject, and well before I begin committing these, I should
>> mention - there are a LOT of function definitions that look like this:
>>
>> static int
>> hpfs_ioctl (
>>     struct vop_ioctl_args /* {
>>         struct vnode *a_vp;
>>         u_long a_command;
>>         caddr_t a_data;
>>         int a_fflag;
>>         struct ucred *a_cred;
>>         struct proc *a_p;
>>     } */ *ap)
>>
>> I (perhaps not thinking too clearly) reformatted these like
> 
> 
> Hmm.
> I am personally very used to having these structure notes
> located inside most of the filesystem code like this. Most of
> other changes that have went on I don't really notice when
> working with the code, ex. having to read something again.
> I really don't think the same would be true with this change.
> 
> -DR

	Seconded, it does not hurt to have these descriptions,
	but anyway, I dont have a problem either way.

		-- Hiten