DragonFly BSD
DragonFly submit List (threaded) for 2004-03
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: patch to fix breakage caused by earlier config(8) patch


From: Matthew Dillon <dillon@xxxxxxxxxxxxxxxxxxxx>
Date: Fri, 5 Mar 2004 00:10:29 -0800 (PST)

:This is a multi-part message in MIME format.
:
:--Multipart=_Thu__4_Mar_2004_22_30_06_-0800_IXRkA2Vv16X6Mmid
:Content-Type: text/plain; charset=US-ASCII
:Content-Transfer-Encoding: 7bit
:
:Erk.  Drat.  Sorry.  A bug slipped in apparently.  Accidentally inverted
:the sense of a test.  Causes a whole bunch of "unknown device removed"
:warnings for me.  The attached patch fixes it.  Sorry again.
:
:-Chris

    Fixed.

    Other things that can be cleaned up:

    * no need to cast void * returning fuctions to strct blah *
      (e.g. no need to cast the return value of malloc)

    * no need to cast non-void-return fuctions to void (e.g. all
      the snprintf, fclose, sscanf, and other calls).

    Config is particularly old code, there is a lot of syntactic
    junk in it.


					-Matt



[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]