Re: DRM Updates part 2

[Erik Paulsen Skaalerud <erik@xxxxxxxxxxxx>]

Craig Dooley wrote:
> This is a better patch from yesterday.  It replaces all OS checks to 
> explicitly test __DragonFly__, Changes DRM_LOCK and DRM_UNLOCK to 
> DRM_LOCK() and DRM_UNLOCK(), and splits memory debugging into 2 files.
> I have only tested it on a radeon, but all the other changes are minimal
> to specific drivers.

With "options radeondrm" in kernel, the buildkernel burps with:






===> dev/drm/tdfx
cc -O -pipe   -D_KERNEL -Wall -Wredundant-decls -Wnested-externs 
-Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith -Winline 
-Wcast-qual  -fformat-extensions -ansi -DKLD_MODULE -nostdinc  -I. -I@ 
-I@/../include  -mpreferred-stack-boundary=2 -ffreestanding -Wall 
-Wredundant-decls -Wnested-externs -Wstrict-prototypes 
-Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual 
-fformat-extensions -ansi -c /usr/src/sys/dev/drm/tdfx/tdfx_drv.c
In file included from /usr/src/sys/dev/drm/tdfx/tdfx_drv.c:86:
@/dev/drm/drm_drv.h: In function `tdfx_cleanup':
@/dev/drm/drm_drv.h:765: structure has no member named `agp'
@/dev/drm/drm_drv.h:765: structure has no member named `agp'
In file included from /usr/src/sys/dev/drm/tdfx/tdfx_drv.c:92:
@/dev/drm/drm_memory.h: At top level:
@/dev/drm/drm_memory.h:64: warning: no previous prototype for `tdfx_calloc'
@/dev/drm/drm_memory.h:134: warning: no previous prototype for 
`tdfx_mtrr_add'
@/dev/drm/drm_memory.h:148: warning: no previous prototype for 
`tdfx_mtrr_del'
@/dev/drm/drm_sysctl.h:212: warning: `tdfx_bufs_info' defined but not used
*** Error code 1

Stop in /usr/src/sys/dev/drm/tdfx.
*** Error code 1

Stop in /usr/src/sys/dev/drm.


Erik.