Re: pccard woes (probably rcNG buglet)

[Emiel Kollof <coolvibe@xxxxxxxxxxxxxxxx>]

Emiel Kollof wrote:

Argh... I need more coffee. Ignore the parent post. I wasn't awake yet. But,
look at this bit of shellscript anyway:

> ------------
>         [ -n "$dhcp_program" ] && dhclient_program="$dhcp_program"
>         [ -n "$dhcp_flags" ] && dhclient_flags="$dhcp_flags"
>         if [ -x "${dhclient_program}" ]; then
>                 if [ `basename ${dhclient_program}` = "dhclient" ]; then
>                         pidfile="/var/run/dhclient.${interface}.pid"
>                         dhclient_flags="${dhcp_flags} -pf ${pidfile}"
>                 fi
>                 ${dhclient_program} ${dhcp_flags} ${interface}
>         else
>                 echo "${dhclient_program}: DHCP client software not
> available"
>         fi
> ------------

Do you see what's wrong? I do. Watch:

>         if [ -x "${dhclient_program}" ]; then
>                 if [ `basename ${dhclient_program}` = "dhclient" ]; then
>                         pidfile="/var/run/dhclient.${interface}.pid"
>                         dhclient_flags="${dhcp_flags} -pf ${pidfile}"
>                 fi
                                      vvvvvvvvvvvvv
>                 ${dhclient_program} ${dhcp_flags} ${interface}
                                      ^^^^^^^^^^^^^

Shouldn't that be ${dhclient_flags} ? Or at least set to include
dhclient_flags? I think this is the pccard_ether bug that's been plagueing
us (well, me and David mostly, I guess) :)

Cheers,
Emiel