Re: DragonFly-2.2.0.34.g50a5f DragonFly_RELEASE_2_2 bin/cpdup cpdup.c

[YONETANI Tomokazu <qhwt+dfly@xxxxxxxxxx>]

On Mon, Apr 27, 2009 at 04:00:14PM -0700, Thomas Nikolajsen wrote:
> 
> commit 50a5f3c29bd22c09c8057e01f92023f2ad9b838f
> Author: Matthew Dillon <dillon@apollo.backplane.com>
> Date:   Fri Apr 17 14:08:31 2009 -0700
> 
>     MFC - CPDUP - Fix lack of error reporting if created target directory cannot stat.
>     
>     Fix a lack of error reporting if a just-created target directory cannot
>     be stat()'ed or chown()'d.
> 
> Summary of changes:
>  bin/cpdup/cpdup.c |   16 ++++++++++++++--
>  1 files changed, 14 insertions(+), 2 deletions(-)
> 
> http://gitweb.dragonflybsd.org/dragonfly.git/commitdiff/50a5f3c29bd22c09c8057e01f92023f2ad9b838f

As I replied to Matt's commit(74fa57e3), this patch alone makes cpdup
complain about failure of chown() (which is OK), and return non-zero
code(which is NOT OK), if you run it as a non-root user, and you're
trying to mirror a tree you don't own.  It also breaks buildworld
as a non-root user, but apparently another commit(17e9c4cc) has fixed
the issue.