DragonFly commits List (threaded) for 2007-08
DragonFly BSD
DragonFly commits List (threaded) for 2007-08
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: cvs commit: src/sys/dev/netif/nfe if_nfe.c


From: Matthew Dillon <dillon@xxxxxxxxxxxxxxxxxxxx>
Date: Fri, 10 Aug 2007 11:26:50 -0700 (PDT)

    Ok, I committed a fix to ip_input.c.  Basically the 1's complement
    checksum was not being properly calculated by the defragmenter.  This
    allows the csum_data to be set to 0xffff with CSUM_PSEUDO_HDR set
    on fragments and for the reassembled result to retain the correct
    csum_data.

    However, we still have an issue in the NFE driver because it is
    marking packet fragments as being UDP/TCP checksumed when clearly it has
    no way of determining that the checksum is actually correct.  So
    right now the udp/tcp checksum is being effectively ignored for
    fragmented packets when rxcsum is turned on in the NFE interface.

    I'm thinking we may want to just junk all the hardware-assisted
    checksums for UDP and TCP (but not IP) when reassembling a fragmented
    packet.

						-Matt



[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]