DragonFly commits List (threaded) for 2007-05
DragonFly BSD
DragonFly commits List (threaded) for 2007-05
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: cvs commit: src/share/man/man4 miibus.4 polling.4 vlan.4 src/sys/config LINT src/sys/boot/forth loader-bootp.conf loader.conf


From: "Sepherosa Ziehau" <sepherosa@xxxxxxxxx>
Date: Mon, 28 May 2007 19:00:48 +0800

On 5/28/07, Christian Brueffer <chris@unixpages.org> wrote:
Hi,

have you actually tested bce(4) polling?  The polling code in the
FreeBSD driver is broken (made the mistake of adding bce(4) to
polling(4) as well ;-)

And there is another thing that is wrong in FreeBSD driver's polling code: in bce_rx_intr() the position where 'count' is tested and decreased is wrong, which may directly lead to non-working polling code. Also there is a dangerous phantom mbuf reference in bce_rx_intr(), if bce_get_buf() fails. I just had made too many changes in bce(4) for myself to remember...

Best Regards,
sephe

--
Live Free or Die



[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]