Re: cvs commit: src/sys/libiconv iconv.c

[Joerg Sonnenberger <joerg@xxxxxxxxxxxxxxxxx>]

On Thu, Mar 08, 2007 at 09:20:00AM -0800, Matthew Dillon wrote:
> 
> :I'd prefer to return EINVAL instead.
> :
> :Joerg
> 
>     It would mean having to scan the strings checking for the \0.  You can't
>     safely call strlen().  If you want to do it, go ahead.  I just had that
>     patch sitting in my tree for a month and figured I should commit it.

In principle memchr. But we don't have that in the kernel right now. I'm
not bothered enough to change that, but it is wiser to not change the
input. E.g. if the overflow of the argument is not intentional, the
following arguments are incorrect anyway.

Joerg