DragonFly commits List (threaded) for 2007-02
[
Date Prev][
Date Next]
[
Thread Prev][
Thread Next]
[
Date Index][
Thread Index]
Re: cvs commit: src/sys/emulation/linux/i386/linprocfs linprocfs.h
:> >DragonFly src repository
:> >
:> > Modified files:
:> > sys/emulation/linux/i386/linprocfs linprocfs.h
:> > Log:
:> > add prototype for linprocfs_init()
:>
:> Is this function used at all (I remember vaguely that it isn't)?
:
:(I didn't notice that my reply didn't make it to commits@ ...)
:No. The driver happens to work without calling linprocfs_init() because
:all it does is to call lwkt_token_init(), which only zero'es the token,
:which is already zero'ed when it was loaded. Besides that,
:lwkt_token_uninit() is called from the bottom of linprocfs_exit(), which is
:wrong, because it's at_exit()'s callback function and can be called
:more than once. Yeah, I know lwkt_token_uninit() is a no-op anyway, so
:yanking lwkt_token_{,un}init() practically solves the problem, but it
:doesn't look right...
:
:Cheers.
I did that in the far past at a time when I thought tokens would be
used more then they area. I wanted an uninit function that could be
used for debugging and tracking tokens. But I never really needed
to debug them at that level so it wound up being unused.
-Matt
Matthew Dillon
<dillon@backplane.com>
[
Date Prev][
Date Next]
[
Thread Prev][
Thread Next]
[
Date Index][
Thread Index]