DragonFly BSD
DragonFly commits List (threaded) for 2005-10
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: cvs commit: src/sys/kern kern_exec.c sysv_ipc.c src/sys/sys proc.h


From: Matthew Dillon <dillon@xxxxxxxxxxxxxxxxxxxx>
Date: Sun, 9 Oct 2005 09:18:04 -0700 (PDT)

:See this patch:  I think it adds too much churd.  Mind you, we can't 
:access p_comm anymore, we always have to find "some" lwp in proc to get 
:the comm, and this seems backwards.  I can commit this to remove p_comm, 
:but I am still feeling that we shouldn't do this.
:
:cheers
:   simon

    Yah, that's too messy.  We absolutely can't be dereferencing the 
    lwp with LIST_FIRST that way.

    All right, put one in the struct proc.  Leave the one in the struct
    thread intact (for kernel threads).  Do not try to allocate it (it's
    very small and it is indispensable as a debugging tool, amount other
    reasons).

    This is an item that we can revist later, it should not be show-stopper
    right now.

						-Matt




[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]