DragonFly BSD
DragonFly commits List (threaded) for 2005-08
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: cvs commit: src/sys/netinet sctp_input.c


From: Joerg Sonnenberger <joerg@xxxxxxxxxxxxxxxxx>
Date: Thu, 11 Aug 2005 07:52:59 +0200
Mail-followup-to: commits@crater.dragonflybsd.org

On Wed, Aug 10, 2005 at 08:16:14PM -0700, Simon Schubert wrote:
> corecode    2005/08/10 20:16:14 PDT
> 
> DragonFly src repository
> 
>   Modified files:
>     sys/netinet          sctp_input.c 
>   Log:
>   Test for malloc returning NULL.
>   Not sure if doing nothing is the best solution.

It certainly isn't. Please don't arbitrarily chance code after mallocs
to short circuit or not panic, unless you really understand the code.
I'm pretty sure that this is wrong.

This code should use M_INTWAIT and not M_NOWAIT, just like the other
examples. 

Joerg



[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]