Re: cvs commit: src/sys/kern vfs_subr.c src/sys/sys vnode.h

[Matthew Dillon <dillon@xxxxxxxxxxxxxxxxxxxx>]

:
:On Wed, Aug 10, 2005 at 04:07:22PM +0100, Hiten Pandya wrote:
:> Joerg Sonnenberger wrote:
:> >joerg       2005/08/10 07:28:34 PDT
:> >
:> >DragonFly src repository
:> >
:> >  Modified files:
:> >    sys/kern             vfs_subr.c 
:> >    sys/sys              vnode.h 
:> >  Log:
:> >  Add vop_write_dirent helper functions, which isolates the caller from
:> >  the layout and setup of struct dirent.
:> >  
:> >  Revision  Changes    Path
:> >  1.60      +23 -0     src/sys/kern/vfs_subr.c
:> >  1.38      +2 -0      src/sys/sys/vnode.h
:> >
:> >
:> >http://www.dragonflybsd.org/cvsweb/src/sys/kern/vfs_subr.c.diff?r1=1.59&r2=1.60&f=u
:> >http://www.dragonflybsd.org/cvsweb/src/sys/sys/vnode.h.diff?r1=1.37&r2=1.38&f=u
:> 
:> Joerg,
:> 
:> Please don't prefix the function name with vop_ as it can be quite 
:> confusing on first read.  Give it some other prefix.
:
:Well, it's a helper function for vop_readdir, that's why I used that
:prefix. Do you have a better idea?
:
:Joerg

    Well, most of the VFS helper functions are prefixed with a 'v',
    as in vfs_subr.c.  It probably shouldn't be a vop_* as those
    are reserved for actual VFS vectors as in vfs_vopops.c.

					-Matt
					Matthew Dillon 
					<dillon@xxxxxxxxxxxxx>