DragonFly BSD
DragonFly commits List (threaded) for 2005-08
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: cvs commit: src/sbin/newfs fscopy.c


From: Joerg Sonnenberger <joerg@xxxxxxxxxxxxxxxxx>
Date: Tue, 9 Aug 2005 15:33:58 +0200
Mail-followup-to: commits@crater.dragonflybsd.org

On Mon, Aug 08, 2005 at 06:37:37PM -0700, Matthew Dillon wrote:
> 
> :joerg       2005/08/08 10:06:18 PDT
> :
> :DragonFly src repository
> :
> :  Modified files:
> :    sbin/newfs           fscopy.c 
> :  Log:
> :  Match "." and ".." with strcmp.
> :  
> :  Revision  Changes    Path
> :  1.7       +2 -5      src/sbin/newfs/fscopy.c
> :
> :
> :http://www.dragonflybsd.org/cvsweb/src/sbin/newfs/fscopy.c.diff?r1=1.6&r2=1.7&f=u
> 
>     Not sure why you did this, the previous code was a whole lot faster.

Are you sure about it being a lot slower? The inline assembly GCC
generates here is less than optimal, but it shouldn't be much slower. On
the other the code depends less on the layout of dirent and is easier to
follow.

Joerg



[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]