DragonFly commits List (threaded) for 2005-07
[
Date Prev][
Date Next]
[
Thread Prev][
Thread Next]
[
Date Index][
Thread Index]
Re: cvs commit: src/include ctype.h src/lib/libc/gen isctype.c tolower.c toupper.c
:..
:> Log:
:> It is not acceptable to index the array out of bounds if an illegal index
:> is passed to a ctype function or macro. Undo the last commit. Emplace an
:> explicit range check for the integer passed to the ctype macros and
:> functions rather then underflowing or overflowing the array. Currently
:> return 0 if the integer is out of range (it might be more appropriate to
:> assert).
:
:It is definately more appropriate to assert IMO.
:
:-Chris
Well, it's hard to say. If the standard said we should assert, then
we should assert. But the programmer might not have the expectation
of an is*() call *EVER* causing the program to exit.
-Matt
Matthew Dillon
<dillon@xxxxxxxxxxxxx>
[
Date Prev][
Date Next]
[
Thread Prev][
Thread Next]
[
Date Index][
Thread Index]