DragonFly BSD
DragonFly commits List (threaded) for 2005-07
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: ctype bug


From: Matthew Dillon <dillon@xxxxxxxxxxxxxxxxxxxx>
Date: Wed, 6 Jul 2005 17:29:11 -0700 (PDT)

:>     No, they never worked like this.  Go back and look at rev 1.1 of
:>     ctype.h in the FreeBSD source repository.  Guess what it does?  It
:>     does a range check.
:
:Where? It masks the high bits off, there by mapping 255 and -1 to the same value.
:That's not correct.

    No, it does a range-check by checking whether the high bits are set
    (thereby checking the full range AND negative values at the same time),
    and calls a C procedure instead of blindly indexing the array.  That's
    my point... the original code was robust, and ours is going to be too.

					-Matt
					Matthew Dillon 
					<dillon@xxxxxxxxxxxxx>



[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]