DragonFly BSD
DragonFly commits List (threaded) for 2005-04
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: cvs commit: src/lib/libc/string strcasecmp.c strnstr.c strpbrk.c strstr.c strtok.c wcschr.c wcspbrk.c wcsrchr.c wcsstr.c wmemchr.c


From: Matthew Dillon <dillon@xxxxxxxxxxxxxxxxxxxx>
Date: Thu, 28 Apr 2005 08:51:07 -0700 (PDT)

:joerg       2005/04/28 06:25:12 PDT
:
:DragonFly src repository
:
:  Modified files:
:    lib/libc/string      strcasecmp.c strnstr.c strpbrk.c strstr.c 
:                         strtok.c wcschr.c wcspbrk.c wcsrchr.c 
:                         wcsstr.c wmemchr.c 
:  Log:
:  DragonFly has decided to depend on char being signed, use it.
:  Use __DECONST for the interface const violations, those are intended.
:  Ansify.

    That is going to break things... everything is fine except
    these lines:

    return (tolower(*us1) - tolower(*--us2));

    Working on signed chars is going to break the sign of the 
    return value.  tolower() does NOT change the sign of the
    argument when no conversion is done.

    Please change it back to unsigned.
  
					-Matt
					Matthew Dillon 
					<dillon@xxxxxxxxxxxxx>



[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]