Re: cvs commit: src/lib/libc/gen tls.c

[Joerg Sonnenberger <joerg@xxxxxxxxxxxxxxxxx>]

On Tue, Mar 08, 2005 at 05:04:38AM -0800, David Xu wrote:
> davidxu     2005/03/08 05:04:38 PST
> 
> DragonFly src repository
> 
>   Added files:
>     lib/libc/gen         tls.c 
>   Log:
>   Import tls support code for static binary from FreeBSD.

Sorry for not commenting earlier, I've been taking the week end off.

(a) Please don't use pragma weak. The GCC implementation is horrible,
e.g. it doesn't verify that the aliased symbol and the real symbol
have matching signatures.
(b) For assertions in libc and co, use _DIAGASSERT.
(c) Why do you want to use TLS_VARIANT_II? I don't feel bound to either
the GNU or the Solaris-ABI here, it's easier to do TLS_VARIANT_I and that's
the recommented way.

Joerg