Re: cvs commit: src/usr.bin/uudecode Makefile uudecode.c

[Liam J Foy <liamfoy@xxxxxxxxxxxxx>]

On Wed, Dec 22, 2004 at 01:06:07PM +0100, Simon 'corecode' Schubert wrote:
> On Wednesday, 22. December 2004 12:25, Liam J. Foy wrote:
> > liamfoy     2004/12/22 03:25:51 PST
> >
> > DragonFly src repository
> >
> >   Modified files:
> >     usr.bin/uudecode     Makefile uudecode.c
> >   Log:
> >   -Setmode can also be caused to fail because of malloc().
> >    We test to see if setmode() has failed. If it has we check errno.
> >    If errno == 0 then we have an invalid file mode. If not malloc
> >    has failed and we the print the error via warn().
> 
> as i already said to ssouhlal@, i consider this to be a bug in setmode(3). it 
> should be fixed to always set an appropriate errno on failure.
> 
> chees
>   simon
> 

I do agree somewhat. I have mentioned this to Joerg but it's no biggie.
However, if people agree it needs to be fixed I will do it.

-- 
- Liam J. Foy
liamfoy@xxxxxxxxxxxxx
New wind is going to find your sail...