DragonFly BSD
DragonFly commits List (threaded) for 2004-12
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: cvs commit: src/usr.bin/newgrp


From: Matthew Dillon <dillon@xxxxxxxxxxxxxxxxxxxx>
Date: Fri, 10 Dec 2004 12:41:15 -0800 (PST)

:liamfoy     2004/12/08 14:00:32 PST
:
:DragonFly src repository
:
:  Modified files:
:    usr.bin/newgrp       newgrp.c 
:  Log:
:  - Check the return value of setenv(). We should check this value since
:    setenv() uses both malloc and realloc.
:  
:  Revision  Changes    Path
:  1.2       +9 -3      src/usr.bin/newgrp/newgrp.c


    That's fine, though the typical way of checking the return 
    value is to check for it < 0 rather then exactly equal to
    -1.  Both are correct, but < 0 is used the most often in the code
    base and considered easier to read.

					-Matt
					Matthew Dillon 
					<dillon@xxxxxxxxxxxxx>



[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]