DragonFly BSD
DragonFly commits List (threaded) for 2004-12
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: cvs commit: src/usr.sbin/pw


From: Matthew Dillon <dillon@xxxxxxxxxxxxxxxxxxxx>
Date: Wed, 1 Dec 2004 11:16:13 -0800 (PST)

:joerg       2004/11/30 12:12:21 PST
:
:DragonFly src repository
:
:  Modified files:
:    usr.sbin/pw          pw_user.c 
:  Log:
:  Switch a strncpy into a strlcpy. I'm not sure why this triggers propolice,
:  the use seems to be correct.
:  
:  Revision  Changes    Path
:  1.4       +1 -2      src/usr.sbin/pw/pw_user.c
:
:http://www.dragonflybsd.org/cvsweb/src/usr.sbin/pw/pw_user.c.diff?r1=1.3&r2=1.4&f=u

    It's probably some other buffer overrun in the same procedure.
    propolice reorders the declarations so it isn't necessarily
    the on you fixed.

    There are also a whole lot of sprintf()'s in there that could be
    changed to snprintf().  That code looks scary.

					-Matt
					Matthew Dillon 
					<dillon@xxxxxxxxxxxxx>



[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]