Re: cvs commit: src/sys/dev/netif/em if_em.c if_em_hw.c if_em_hw.h

[Joerg Sonnenberger <joerg@xxxxxxxxxxxxxxxxx>]

On Tue, May 11, 2004 at 12:48:19PM -0400, David Rhodus wrote:
> OOps
> 
> linking kernel.debug
> if_em_hw.o: In function `em_reset_hw':
> /usr/home/drhodus/HEAD/i386/i386/src/sys/dev/netif/em/if_em_hw.c:363:  
> undefined reference to `em_write_reg_io'
> /usr/home/drhodus/HEAD/i386/i386/src/sys/dev/netif/em/if_em_hw.c:383:  
> undefined reference to `em_write_reg_io'
> *** Error code 1

Argh! OK, I'll investigate the Intel docs wether this has to be direct
IO and revert the patch in that situation. But this has to wait 4 hours.
Other possibility is adding another bus tag for direct IO, but the direct
inl / outl must go.

Joerg

> 
> -DR
> On May 11, 2004, at 10:00 AM, Joerg Sonnenberger wrote:
> 
> >joerg       2004/05/11 07:00:20 PDT
> >
> >DragonFly src repository
> >
> >  Modified files:
> >    sys/dev/netif/em     if_em.c if_em_hw.c if_em_hw.h
> >  Log:
> >  - remove em_adapter_list, it was not used for anything beside adding  
> >and
> >    removing entries
> >  - fix const warning for em_strings
> >  - convert u_intXX_t to uintXX_t
> >  - style(9) changes for whitespace e.g. consistent use of tabs
> >  - use snprintf to build the adapter version string, we are embedding  
> >a
> >    string which could grow in size
> >  - remove check for device_get_softc(dev) == NULL, this must not  
> >happen
> >  - prefer device_printf and if_printf over printf("em0d: ...",  
> >addapter->unit)
> >  - make some pointer checks explicit against NULL
> >  - remove some of the #ifdef FreeBSD cases which are not interesting  
> >for us
> >  - remove trailing return; in void functions
> >  - use the pci accessor functions for the subsystem id and vendor
> >  - start using bus_alloc_resource_any
> >  - remove em_read_reg_io, em_write_reg_io, em_io_read and em_io_write,
> >    those are unused and doesn't fit into our newbus scheme.
> >
> >  Revision  Changes    Path
> >  1.13      +738 -916  src/sys/dev/netif/em/if_em.c
> >  1.6       +0 -38     src/sys/dev/netif/em/if_em_hw.c
> >  1.6       +0 -5      src/sys/dev/netif/em/if_em_hw.h
> >
> >
> >http://www.dragonflybsd.org/cvsweb/src/sys/dev/netif/em/if_em.c.diff? 
> >r1=1.12&r2=1.13&f=h
> >http://www.dragonflybsd.org/cvsweb/src/sys/dev/netif/em/ 
> >if_em_hw.c.diff?r1=1.5&r2=1.6&f=h
> >http://www.dragonflybsd.org/cvsweb/src/sys/dev/netif/em/ 
> >if_em_hw.h.diff?r1=1.5&r2=1.6&f=h
> 
>