Re: cvs commit: src/sys/dev/raid/ips ips_commands.c

[YONETANI Tomokazu <qhwt+dragonfly-commits@xxxxxxxxxx>]

On Wed, Feb 25, 2004 at 07:46:54AM -0800, Joerg Sonnenberger wrote:
> joerg       2004/02/25 07:46:54 PST
> 
> DragonFly src repository
> 
>   Modified files:
>     sys/dev/raid/ips     ips_commands.c 
>   Log:
>   Fix use after free / double free bugs. Return an error in error conditions.
>   
>   Submitted by YONETANI Tomokazu <qhwt+dragonfly-submit@xxxxxxxxxx>
>   
>   Revision  Changes    Path
>   1.2       +11 -2     src/sys/dev/raid/ips/ips_commands.c
> 
> 
> http://www.dragonflybsd.org/cvsweb/src/sys/dev/raid/ips/ips_commands.c.diff?r1=1.1&r2=1.2&f=h

Thanks, but one hunk is missed; did my patch create a .rej file?

Index: sys/dev/raid/ips/ips_commands.c
===================================================================
RCS file: /home/source/dragonfly/cvs/src/sys/dev/raid/ips/ips_commands.c,v
retrieving revision 1.2
diff -u -r1.2 ips_commands.c
--- sys/dev/raid/ips/ips_commands.c     25 Feb 2004 15:46:54 -0000      1.2
+++ sys/dev/raid/ips/ips_commands.c     26 Feb 2004 01:23:25 -0000
@@ -555,6 +555,7 @@
 		free(status, M_DEVBUF);
 		device_printf(sc->dev, "ERROR: unable to get a command! "
 		    "can't send ffdc reset!\n");
+		return 1;
 	}
 	if (COMMAND_ERROR(status)) {
 		free(status, M_DEVBUF);