Re: [issue1106] Network-related crash on boot

["Sepherosa Ziehau" <sepherosa@xxxxxxxxx>]

On Tue, Aug 5, 2008 at 11:54 AM, Tim <t-df@timdarby.net> wrote:
> Sepherosa Ziehau wrote:
>>
>> Sepherosa Ziehau <sepherosa@gmail.com> added the comment:
>>
>> Please test the attached patch.
>>
>> Best Regards,
>> sephe
>>
>> _____________________________________________________
>> DragonFly issue tracker <bugs@lists.dragonflybsd.org>
>> <https://bugs.dragonflybsd.org/issue1106>
>> _____________________________________________________
>
> It works!  So, out of curiosity, what does this patch do?

Thank you for testing!

- Driver should only check IFF_RUNNING in intr handler, not IFF_UP
- SIOC{ADD,DEL}MULTI will try to reprogram hardware's mcast filter,
but that should only be done after device is running (IFF_RUNNING)
- For unknown reason xircom's mcast filter programming function turns
on IFF_RUNNING, which is wrong.  I nuked that line and added an
assertion in xircom's mcast programming function to make sure that NIC
is running, but I forgot that in dc_init() IFF_RUNNING is turned on
after mcast filter programming (that's the cause of the latest panic
:P)

Best Regards,
sephe

-- 
Live Free or Die