Re: installer networking

[Chris Pressey <cpressey@xxxxxxxxxxxxxxx>]

On Tue, 1 Feb 2005 09:59:10 -0500
"George Georgalis" <george@xxxxxxxxx> wrote:

> [...]
> On Tue, Feb 01, 2005 at 01:09:39AM -0800, Chris Pressey wrote:
> >You can look at function fn_assign_ip() in fn_configure.c:
> >
> >http://www.bsdinstaller.org/cgi-bin/cvsweb.cgi/installer/src/backend
> >/installer/fn_configure.c
> >
> >But, by the looks of the code, it actually does write your selected
> >network settings to rc.conf, even if they failed to connect. 
> >Possibly all that is needed is a more informative error message.
> 
> 
> I can try it again later today, but what I think what is happening
> is the inform function causes a break from
> 	if (dfui_id_is(dfui_response_get_action_id(r), "ok"))
> (about 22 lines above) and subsequent config_var_set doesn't happen.

I don't see how that could happen; like most C functions, inform()
always returns to its caller.  (Unless something catastrophic happens,
in which case the entire program will exit.)

Note that the config_var_set doesn't cause it to be written to
/etc/rc.conf immediately; everything is written in one shot when you
finish configuring the system (effectively, whenever you return to the
main menu.)

> I couldn't find where inform is defined though.

http://www.bsdinstaller.org/cgi-bin/cvsweb.cgi/installer/src/lib/libinstaller/uiutil.c

> "Note: root's new password will appear in the install log. "
> is this really necessary?

Can it hurt?  Someone mentioned install-fests...

-Chris