Re: Puzzling makefile interactions in some ports.

[Chris Pressey <cpressey@xxxxxxxxxxxxxxx>]

On Sun, 09 May 2004 11:44:17 -0700
walt <wa1ter@xxxxxxxxxxxxx> wrote:

> I think I've found part of the reason for the 'make clean'
> error I posted about last week.  The trail leads from
> 'make clean' to 'make clean-depends' and from there to
> 'make all-depends-list', which is defined in bsd.port.mk.
> 
> Can anyone reproduce this for me:
> 
> #cd /usr/ports/print/ghostscript-gnu
> #make all-depends-list
> &&
> -B
> /usr/dfports/x11/XFree86-4-libraries
> /usr/ports/devel/gettext
> /usr/ports/devel/gmake
> /usr/ports/devel/imake-4
> /usr/ports/print/freetype2
> /usr/ports/x11-fonts/fontconfig
> /usr/ports/x11/XFree86-4-libraries
> DRAGONFLY
> OVERRIDE
> USING
> WARNING,
> cd
> make
> run-depends-list
> 
> You can see above that there are several lines in the list
> which don't belong there, since it should be a list of
> packages only.  The first line '&&' is actually what seems
> to cause the error message in 'make clean-depends'.

Excellent detective work, if I may say so - this completely baffled me
when I ran into it the first time.

I think I found the cause by logically extrapolating from your report:
all-depends-list is a combination of build-depends-list and
run-depends-list.  But those targets aren't filtered out when printing
the warning, and that output gets in the way.  Try the attached patch
and see if it fixes it (it seems to, for me.)

> Also, XFree-libraries appears twice:  first under /usr/dfports
> and again under /usr/ports.  Anyone know if that is the desired
> behavior?

Probably not.  It only shows up once, with this patch.

And if someone higher-up can confirm that this is the right solution
(or, uh, "right enough for now",) I can commit it shortly.

-Chris

Index: bsd.port.mk
===================================================================
RCS file: /home/dcvs/src/share/mk/bsd.port.mk,v
retrieving revision 1.13
diff -u -r1.13 bsd.port.mk
--- bsd.port.mk	2 Mar 2004 15:03:00 -0000	1.13
+++ bsd.port.mk	9 May 2004 19:22:27 -0000
@@ -66,7 +66,7 @@
 TARGETS+=	tags
 
 .undef PORTSDIR
-.if !make(package-depends-list) && !make(all-depends-list)
+.if !make(package-depends-list) && !make(all-depends-list) && !make(run-depends-list) && !make(build-depends-list)
 .BEGIN:
 	@echo "WARNING, USING DRAGONFLY OVERRIDE ${DFPORTSDIR}/${PORTPATH}"
 	cd ${DFPORTSDIR}/${PORTPATH} && ${MAKE} -B ${.TARGETS}